-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Update firearm name for consistency #83875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SchrodingerSig
wants to merge
17
commits into
CleverRaven:master
Choose a base branch
from
SchrodingerSig:firearm-name-change
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update firearm name for consistency #83875
SchrodingerSig
wants to merge
17
commits into
CleverRaven:master
from
SchrodingerSig:firearm-name-change
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
wont be ablet to work on translation project till mid-end of december (due to busy irl) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
none
Purpose of change
Finding some firearm are following different naming rule while going through firearm related strings on fransifex.
Describe the solution
Update em (listed below).
(I have only bare minimum knowledge at firearms and making these changes purely base on translator mindset, so if theres firearms name that shouldnt be changed please let me know.)
id: remington_700_308 - Remington Model 700 -> Remington 700 .308 rifle
ref. Remington 700 .270 Win rifle & Remington 700 .30-06 rifle
id: steyr_scout_mag_makeshift - makeshift scout rifle 3-round magazine/makeshift Steyr Scout 3-round magazine -> Scout rifle 3-round makeshift magazine/Steyr Scout 3-round makeshift magazine;
id: steyr_scout_mag_makeshift (desc) - A makeshift 3-round steel box magazine for the scouting rifle, held together by duct tape and hope... -> A improvised 3-round steel box magazine held together by duct tape and hope, for use with the scouting rifle...
id: smg_40_mag - makeshift .40 20-round magazines -> .40 20-round makeshift magazines
ref. there are like 7 other makeshift magazines. SCAR-H 5-round makeshift magazine, Thompson 20-round makeshift magazine, ect.
id: winchester_94_3030 - lever-action rifle -> 8-shot lever-action rifle
id: marlin_336_3030 - lever-action rifle -> 6-shot lever-action rifle
ref. 7-shots .357 revolver ...hold on a minute 🤔
id: sw_619 - 7-shots .357 revolver -> 7-shot .357 revolver
better.
id: fn_fal_semi (desc) - allowing the FAL to keep up even among modern competitors. -> ...allowing it to keep up even among modern competitors.
removing "the FAL" as its description didnt mention its name being FN FAL
id: papm77 - PAP M77 rifle -> Zastava PAP M77
id: zpapm90 - ZPAP M90 -> Zastava ZPAP M90
ref. Zastava ZPAP M70 (AK-47 rifle)
id: rp63 - .357**-caliber** snub-nosed revolver -> .357 snub-nosed revolver
ref. .357 revolver, .44 revolver, ect
id: sw642 - S&W model 642 -> S&W 642 revolver
id: model_10_revolver - S&W Model 10 -> S&W Model 10 revolver
id: sw_619 - S&W 686 Plus -> S&W 686 Plus revolver
id: sw617 - S&W 617 -> S&W 617 revolver
id: 460_xvr - S&W 460XVR -> S&W 460XVR revolver
ref. S&W 629 revolver, S&W 500 revolver, S&W 610 revolver
Undecided:
id: number4_mki - Lee-Enfield No. 4 Mk I rifle
No reason ones called SMLE and other called Lee-Enfield, though which one should be changed is undecided.
Describe alternatives you've considered
none
Testing
none. text changes only
Additional context
none